Nd file error in Bioformat 5.1.6

[phm]

Hi,

I can't open nd files with bioformat 5.1.6

(Fiji Is Just) ImageJ 2.0.0-rc-42/1.50d; Java 1.7.0_80 [64-bit]; Linux 4.2.0-18-generic; 43MB of 22398MB (<1%)

java.lang.ArithmeticException: Non-terminating decimal expansion; no exact representable decimal result.
at java.math.BigDecimal.divide(BigDecimal.java:1616)
at loci.formats.in.MetamorphReader.initFile(MetamorphReader.java:810)
at loci.formats.FormatReader.setId(FormatReader.java:1426)
at loci.plugins.in.ImportProcess.initializeFile(ImportProcess.java:505)
at loci.plugins.in.ImportProcess.execute(ImportProcess.java:143)
at loci.plugins.in.Importer.showDialogs(Importer.java:140)
at loci.plugins.in.Importer.run(Importer.java:76)
at loci.plugins.LociImporter.run(LociImporter.java:78)
at ij.IJ.runUserPlugIn(IJ.java:212)
at ij.IJ.runPlugIn(IJ.java:176)
at ij.IJ.runPlugIn(IJ.java:165)
at HandleExtraFileTypes.openImage(HandleExtraFileTypes.java:499)
at HandleExtraFileTypes.run(HandleExtraFileTypes.java:72)
at ij.IJ.runUserPlugIn(IJ.java:212)
at ij.IJ.runPlugIn(IJ.java:176)
at ij.IJ.runPlugIn(IJ.java:165)
at ij.io.Opener.openWithHandleExtraFileTypes(Opener.java:503)
at ij.io.Opener.openImage(Opener.java:369)
at ij.io.Opener.openImage(Opener.java:243)
at ij.io.Opener.open(Opener.java:110)
at ij.io.Opener.openMultiple(Opener.java:218)
at ij.plugin.Commands.run(Commands.java:25)
at ij.IJ.runPlugIn(IJ.java:182)
at ij.Executer.runCommand(Executer.java:136)
at ij.Executer.run(Executer.java:65)
at java.lang.Thread.run(Thread.java:745)

Philippe

[sbesson]

Hi Philippe,

thanks for the bug report, this error seems to have been caused by the changes https://github.com/openmicroscopy/bioformats/pull/1966 which were included in Bio-Formats 5.1.5. However, none of the Metamorph files in our data repository shows this error which is why we did not catch this bug as part of our daily testing.

In order for us to provide a bug fix, would it be possible for you to upload a sample file at http://qa.openmicroscopy.org.uk/qa/upload/?

Best regards,
Sebastien

[phm]

Hi Philippe,

thanks for the bug report, this error seems to have been caused by the changes https://github.com/openmicroscopy/bioformats/pull/1966 which were included in Bio-Formats 5.1.5. However, none of the Metamorph files in our data repository shows this error which is why we did not catch this bug as part of our daily testing.

In order for us to provide a bug fix, would it be possible for you to upload a sample file at http://qa.openmicroscopy.org.uk/qa/upload/?

Best regards,
Sebastien

Hi Sebastien,

The files have uploaded, ID=16907

Philippe

[sbesson]

Thanks Philippe,

we'll take a look at the files and get back to you soon.

Best,
Sebastien

[dgault]

Hi Philippe,

Thanks again for reporting this issue and uploading sample files. The issue was indeed caused by updates we made to the Metamorph reader in Bio-Formats 5.1.5

I have submitted the following PR to resolve the issue which should be included in the next Bio-Formats release 5.1.7:
https://github.com/openmicroscopy/bioformats/pull/2102


With Thanks,
David